Skip to content

#736 Add and test UKCM2 plugin#790

Merged
Matthew Mizielinski (matthew-mizielinski) merged 26 commits intomainfrom
736_UKCM2_plugin
Feb 11, 2026
Merged

#736 Add and test UKCM2 plugin#790
Matthew Mizielinski (matthew-mizielinski) merged 26 commits intomainfrom
736_UKCM2_plugin

Conversation

@matthew-mizielinski
Copy link
Copy Markdown
Collaborator

@matthew-mizielinski Matthew Mizielinski (matthew-mizielinski) commented Feb 3, 2026 •
edited
Loading

Changes include:

  • Import of mappings for UKCM2
  • adaptations to new files in CMOR tables repo
  • update of mappings for UKESM1-3

Changes have been tested with a run through of CDDS for the atmosphere only

@matthew-mizielinski
Copy link
Copy Markdown
Collaborator Author

Matthew Mizielinski (matthew-mizielinski) commented Feb 3, 2026

All tests pass for me

@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Lauren Boon (mo-laurenboon) commented Feb 6, 2026

Please do not merge this branch quite yet, there will be some additional changes to the plugin json file.

@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Lauren Boon (mo-laurenboon) commented Feb 6, 2026

Extract is now working correctly for streams "inm", "onm", "ind" and "ond". All required changes to the model json have now been made.

@mo-laurenboon Lauren Boon (mo-laurenboon) mentioned this pull request Feb 10, 2026
Open
@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Lauren Boon (mo-laurenboon) commented Feb 10, 2026

Please note this may require an additional single line update to a cycling frequency value for the ond stream in the mappings file. I am currently testing the change manually before editing the mappings file.

@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Lauren Boon (mo-laurenboon) commented Feb 10, 2026

Required changes have now been applied

@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Lauren Boon (mo-laurenboon) commented Feb 11, 2026

Are the "null" and "UNKNOWN" values within cdds/cdds/common/plugins/cmip7/data/streams/streams_config.json expected or potentially the result of a mappings error?

mo-laurenboon
Lauren Boon (mo-laurenboon) previously approved these changes Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mo-laurenboon Lauren Boon (mo-laurenboon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Test runs for UKCM2 also seem happy.

mo-laurenboon
Lauren Boon (mo-laurenboon) approved these changes Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mo-laurenboon Lauren Boon (mo-laurenboon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-mizielinski Matthew Mizielinski (matthew-mizielinski) merged commit 45aafd4 into main Feb 11, 2026
1 check passed
Closed
@mo-laurenboon Lauren Boon (mo-laurenboon) mentioned this pull request Mar 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mo-laurenboon Lauren Boon (mo-laurenboon) mo-laurenboon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthew-mizielinski @mo-laurenboon